search

JuliaMath / openspecfun

A collection of special mathematical functions
Other
35 stars 20 forks source link

[Bug] u_int_* is implementation specific and should never be used #34

Closed ghost closed 8 years ago

ghost commented 8 years ago

sys/types.h and its u_int_* should never be used. stdint.h and its uint_* is the C99 standard.

yuyichao commented 8 years ago

I believe sys/types.h is standard. u_int*_t's are not though.

ghost commented 8 years ago

You're right. My post wasn't clear. It's u_int_* only that's not standard.

ghost commented 8 years ago

Here's the fix. Please review and if good apply. http://sprunge.us/EGTf

yuyichao commented 8 years ago

Could you please submit a pull request instead?

ghost commented 8 years ago

Are the patches good? If so I think I can reproduce them in the pull request format.

yuyichao commented 8 years ago

FWIW, are __BEGIN_DECLS and __END_DECLS actually used anywhere? Seems that we can simply remove them.

ghost commented 8 years ago

Even better then. Less is more. I'll remove the cruft.

ViralBShah commented 8 years ago

I wish we can just have julia versions of many of these things eventually.

ghost commented 8 years ago

@ViralBShah I wish julia could be portable and work everywhere with a single version. Why add complexity? A single standard version that works anywhere is much more rewarding. Less is more.

This is my opinion.