JuliaMolSim / EmpiricalPotentials.jl

Empirical interatomic potentials with Julia, AtomsBase and AtomsCalculators
MIT License
2 stars 0 forks source link

Hessian Prototype #21

Closed cortner closed 1 month ago

cortner commented 2 months ago

This PR is to provide a prototype hessian implementation. This is needed for a different project, so I can't wait around anymore until the community decides on the AtomsCalculators format.

Needs the FD PR in AtomsCalculators to be merged first.

Comments

cortner commented 2 months ago

this is ready for a review. ~Units still need to be taken care of.~

cortner commented 1 month ago

Tests only fail because other PRs need to be merged. Locally all tests pass.

cortner commented 1 month ago

this is now superceded by #22 - but some of the tests still need to be moved over.

cortner commented 1 month ago

those tests are currently in ACU - not clear yet where they should actually live, but I think the PR can now be closed.