JuliaMolSim / GeometryOptimization.jl

Geometry optimization for molecular simulation
https://juliamolsim.github.io/GeometryOptimization.jl/
MIT License
6 stars 1 forks source link

Generalize atoms clamping #2

Open CedricTravelletti opened 10 months ago

CedricTravelletti commented 10 months ago

As described in https://github.com/JuliaMolSim/GeometryOptimization.jl/pull/1#discussion_r1431722115 , one should be able to restrict atoms movement along a submanifold, e.g. certain atoms are allowed to slide on a surface. Currently atoms are either completely clamped or not.

Possible implementation directions include:

cortner commented 5 months ago

there is a question whether this should be part of Geometry optimization or part of AtomsBase. Is the constraint part of the system or part of the simulation? E.g. I can see that one might want to do other kinds of simulation tasks with the same constraints....

rkurchin commented 5 months ago

I vaguely recall a conversation to this effect on one of the Zoom calls (or maybe it was at JuliaCon hackathon last summer?). If I had to pick one, I think I'd say it's part of the simulation, but it's probably really a separate thing and if we could make it "portable" in the sense you describe, that would be ideal.

cortner commented 5 months ago

Maybe the AtomsBase interface should be extended for managing constraints but not necessarily provide implementations of constraints or just very simple examples.

I am also very unsure about this tbh.

mfherbst commented 4 months ago

Often when people setup structures they provide "additional atoms" not because they care about them, but only because that is needed for the modelling. From the philosophical point of view it's thus a numerical trick, but from the practitioner point of view I think it will be very confusing to have this separated from the structure. I think the practical expectation is more that you set up your system (including the constraints) and then just apply certain computational methods to it, that all do their best to respect the constraints.

But I agree with the general uncertainty how to handle this.