Closed axsk closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
a2076b0
) 83.77% compared to head (3c10607
) 83.77%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks for fixing this. I asked on Slack and it seems that this function is indeed not importable. Looks good to me.
On machines where there is no display you can run the tests with VISTESTS=0 julia test/runtests.jl
.
Using the new extension system, it seems the
dualize
function defined inFordwardDiff
'sForwardDiffStaticArraysExt
extension module is not importable (at least I could not manage to do it).However, since the signature defined here (in Molly) is only used from within Zygote, I supposed it's safe to simply define it independent of
ForwardDiff
'sdualize
. Maybe thisdualize
could/should be calledoffset_dualize
to clearly distinguish it?Using this little trick allowed me to load Molly on 1.9.0rc1. However, I couldn't run
Pkg.test
because it fails due to some GL stuff not working (running it on a remote node without even an display server) and I was not using the differentiable capabilities so far, so I cannot say anything about correctness.