JuliaMolSim / Molly.jl

Molecular simulation in Julia
Other
371 stars 51 forks source link

Warn if eltype positions/velocities are not isbits #166

Closed ejmeitz closed 4 months ago

ejmeitz commented 4 months ago

From #162

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (bc319c2) 72.18% compared to head (953432e) 72.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #166 +/- ## ========================================== - Coverage 72.18% 72.13% -0.05% ========================================== Files 35 35 Lines 5274 5276 +2 ========================================== - Hits 3807 3806 -1 - Misses 1467 1470 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jgreener64 commented 4 months ago

Great, maybe just change Vector{SVector{}} to a vector of SVectors since we also allow CuArrays.

ejmeitz commented 4 months ago

Done