Updated library to import sdl_gfx

JuliaMultimedia / SimpleDirectMediaLayer.jl

SDL2

MIT License

81 stars 18 forks source link

Updated library to import sdl_gfx #75

Closed Kyjor closed 9 months ago

Kyjor commented 9 months ago

Here is a fix for the sdl_gfx functions not actually working when called. The package SDL2_gfx_jll wasn't listed as a dependency, and I updated the calls in LibSDL2 to actually use them. Eventually I would like to update to a newer version of the package, but this is what we have at the moment.

Kyjor commented 9 months ago

No that's fine, thank you! When I get a chance either today or tomorrow, I can address these issues. This is super helpful!

JamesWrigley commented 9 months ago

I tried your branch locally and got it working, the only changes I made were:

Deleting the compat bounds from gen/Project.toml and updating all the dependencies
Blacklisting SDL_BYTEORDER and SDL_FLOATWORDORDER, those depend on some other property that isn't captured for some reason.

After that, all the tests passed.

Kyjor commented 9 months ago

Tried it with a linux machine instead of windows and it worked! I want to add a few smoke tests for the added libraries. Thank you! Definitely learned some useful stuff about Clang.jl that I can use for my other stuff 😄

Kyjor commented 9 months ago

Okay I actually have it working and added a simple test for each header file from the gfx library. I think it's ready for an official review. If you happen to know anyone who can, would you direct them here please? Thanks!

JamesWrigley commented 9 months ago

Noice noice :+1: Maybe @Gnimuc?

Gnimuc commented 9 months ago

I think it's good to merge.

Kyjor commented 9 months ago

Anything else I need to do here? Is there an ETA on merging? I'd like to use this soon. Thanks!