JuliaMultimedia / SimpleDirectMediaLayer.jl

SDL2
MIT License
81 stars 18 forks source link

Restrict SDL_ttf and SDL_mixer to mac-only. #9

Closed NHDaly closed 6 years ago

NHDaly commented 6 years ago

Since we can't get these libraries to work on windows, I've just disabled them if not running on an apple platform. This fixes the appveyor build for windows, at least. So SDL will at least be usable from windows...

jonathanBieler commented 6 years ago

I guess that will do the trick until someone really needs it on windows.

It seems the online osx test also has some issue, probably because the machine doesn't have a sound interface:

https://travis-ci.org/jonathanBieler/SDL2.jl/jobs/355465545#L493

I guess disabling the test when SDL2.Mix_OpenAudio returns -1 would make sense. There's a way to query the exact error though, I wanted to do something about error handling but I haven't had much time lately.

NHDaly commented 6 years ago

Ah, yeah i see. I bet you're right.

Yeah, disabling the test if the audio subsystem isn't enabled makes sense to me. Np about being busy, i def understand! :D I think even as is, it's probably in a good enough state to attempt registering as a package if you wanted to. There's lots of little stuff like that that would be nice to do, but i think it's in decent shape.