search

JuliaMusic / MIDI.jl

A Julia library for handling MIDI files
https://juliamusic.github.io/JuliaMusic_documentation.jl/latest/
MIT License
67 stars 22 forks source link

push!() in readme #88

Closed CNelias closed 6 years ago

CNelias commented 6 years ago

the push!(Notes, Note) is not working in the example given in the readme file

Datseris commented 6 years ago

Fixed on master, you can use Pkg.checkout("MIDI") to obtain the fix.

CNelias commented 6 years ago

Super ! thanks. I've read parts of the code, now I understand a bit better how the different types are treated (if there was a problem on this I you would have already seen it anyway). What happens if someone tries to write several tracks in a file created as type "0" ? Do we get an error or does it just creates in the end a file that is unreadable ?

----- Mail original ----- De: "George Datseris" notifications@github.com À: "JoelHobson/MIDI.jl" MIDI.jl@noreply.github.com Cc: "corentin nelias" corentin.nelias@insa-lyon.fr, "Author" author@noreply.github.com Envoyé: Mardi 27 Février 2018 16:16:40 Objet: Re: [JoelHobson/MIDI.jl] push!() in readme (#88)

Fixed on master, you can use Pkg.checkout("MIDI") to obtain the fix.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/JoelHobson/MIDI.jl/issues/88#issuecomment-368912085

Datseris commented 6 years ago

Just try it out

JoelHobson commented 6 years ago

@johncwok I suspect it'll end up in a file that's unreadable. It's been a long time since I've been deep in the code for this, but I don't remember there being any error checking for that.