search

JuliaMusic / MusicManipulations.jl

Manipulate music data, humanize, quantize and analyze music performances with Julia
MIT License
46 stars 7 forks source link

Allowing grid to start at non-zero value. #40

Closed CNelias closed 4 years ago

CNelias commented 5 years ago

I change line 7 to : 

 if abs(grid[1] - grid[end]) != 1

The drawback of this approach is that one has to explicitely write a grid of the form [x,...,1+x], the advantage is that the code doesn't need to be otherwise modified and therefore works as smoothly as before.

Datseris commented 5 years ago

This must be tested some how if it is to be merged! Please add just one more test about this in the test suite.

Datseris commented 5 years ago

In addition, you should change the documentation string of the function quantize to reflect this change.

Datseris commented 5 years ago

bump @johncwok

Datseris commented 4 years ago

I've you want to work on this, please re-open the PR.