search

JuliaMusic / MusicProcessing.jl

Music Processing Library in Julia
Other
87 stars 15 forks source link

Adding dependencies and writing tests for audio.jl #13

Closed jparcill closed 4 years ago

jparcill commented 4 years ago

Functionality is pretty much there for audio.jl after writing tests and also playing around with them in a jupyter notebook. Functions that I haven't fixed yet are the ones that depend on other files like TFR.jl

Datseris commented 4 years ago

Great, thanks for adding tests! However at the moment there are many failings: https://travis-ci.org/github/JuliaMusic/MusicProcessing.jl/jobs/725473247 Can you have a look?

jparcill commented 4 years ago

Yup, I wrote those tests for functions that I havent fixed yet. Those functions rely on TFR.jl which I'll most likely focus on next

Datseris commented 4 years ago

Thanks for continuing to work here @jparcill ! Little by little, this will be in soon!

jparcill commented 4 years ago

Great news. Though I haven't written up the thorough tests yet, just trying the functions out in a jupyter notebook with a WAV file I had lying around, a lot of the functionality looks good!

Including:

to name a few

Datseris commented 4 years ago

Very nice! Once you have some basic tests down, I'll do a final review and we merge this!

ashwani-rathee commented 4 years ago

Hey Guys @Datseris @jparcill,I would love to help ,just getting it up and running for now in notebook and testing it out a bit...can you guide/suggest me a little on what I should work/try on??

Datseris commented 4 years ago

@ashwani-rathee thanks for the interest. FOr sure @jparcill can guide you more, but the main thing I believe is to write passing tests in the /test folder.

ashwani-rathee commented 4 years ago

@jparcill I have never written a test before,can you guide on what I should learn\read???How long this task of writting test will continue??I saw the files of chroma.jl/constantq.jl empty that could also be starting point for me,but I would love to try hands on testing..

ashwani-rathee commented 4 years ago

@jparcill can you share your jupyter notebook in which you're exploring??

jparcill commented 4 years ago

@jparcill can you share your jupyter notebook in which you're exploring??

Hey @ashwani-rathee sure. How should I send it?

Datseris commented 4 years ago

@jparcill , should we merge this PR, to allow for different people to open PRs, since there is interest? Then you can please outline in #10 what remains to be done?

jparcill commented 4 years ago

Yeah that makes sense! School's unfortunately getting busy again and it'd be great to have more helping hands

Datseris commented 4 years ago

OKay, no problem, just make sure to underline in #10 what remains from this PR !

ashwani-rathee commented 4 years ago

@jparcill can you share your jupyter notebook in which you're exploring??

Hey @ashwani-rathee sure. How should I send it? Email:ab669522@gmail.com as attachment or share google drive link,don't know more faster way :)