Would an AbstractLineSearchType be a good idea?

JuliaNLSolvers / LineSearches.jl

Line search methods for optimization and root-finding

Other

120 stars 34 forks source link

Would an AbstractLineSearchType be a good idea? #171

Closed kellertuer closed 2 days ago

kellertuer commented 1 year ago

I am using LineSearches in one of my packages – and just to be able to write something generic an abstract linesearch type for all linesearch structs would be great. Is this something that others find helpful as well? Then I think I could do a PR.

pkofod commented 5 days ago

You mean in another package? It would mean that different packages would have to follow a common API? Or did you mean for the line searches in this package?

kellertuer commented 5 days ago

Maybe a bit of both. For now Manopt.jl has its own line searched but also an extension to use the ones from here, cf https://github.com/JuliaManifolds/Manopt.jl/blob/master/ext/ManoptLineSearchesExt.jl and our wrapper type https://github.com/JuliaManifolds/Manopt.jl/blob/master/src/helpers/LineSearchesTypes.jl

So with a generic API here, that wrapper might be a bit nicer, but with a LineSearchesBase.jl API like package, I could maybe even remodel my line searches to fit such an API as well.

kellertuer commented 2 days ago

But we can also just stick to the wrapper for now, maybe.