search

JuliaNLSolvers / NLSolvers.jl

No bells and whistles foundation of Optim.jl
https://julianlsolvers.github.io/NLSolvers.jl/dev/
MIT License
27 stars 8 forks source link

NEqProblem fails with BFGS and LBFGS #17

Open longemen3000 opened 3 years ago

longemen3000 commented 3 years ago

https://github.com/JuliaNLSolvers/NLSolvers.jl/blob/486e562e32322c9443617a935b4ef8a5ec387f59/src/nlsolve/linesearch/newton.jl#L25-L29 asks the scheme for a ´reset_age´ field, but there isnt one. with that, only newton works on NEqProblems. maybe using a function instead of a field access could solve the problem?

pkofod commented 3 years ago

I see what you're getting at, but I think everything here should just be annotated Newton. Then, another dispatch can wrap the objective in a meritobjective type and minimize it.