JuliaNLSolvers / NLSolvers.jl

No bells and whistles foundation of Optim.jl
https://julianlsolvers.github.io/NLSolvers.jl/dev/
MIT License
27 stars 9 forks source link

Anderson: incorrect initialization of γv0 #49

Closed longemen3000 closed 1 year ago

longemen3000 commented 1 year ago

tests pass locally.

pkofod commented 1 year ago

Is this because you were using something like float32 ? Would be good to have a test here.

ararslan commented 1 year ago

Would be good to have a test here.

This actually fixes an existing test that's failing on master. See e.g. the CI log for the most recent commit: https://github.com/JuliaNLSolvers/NLSolvers.jl/actions/runs/4686200423/jobs/8304028701

longemen3000 commented 1 year ago

It was failing because the length γv0 was effective memory (0 in that part of the code) instead of the full memory Before #47, it was passing because it wasn't using restricted memory anyway

longemen3000 commented 1 year ago

@pkofod does this require any specific test? given the comments