search

JuliaNLSolvers / NLSolversBase.jl

Base package for optimization and equation solver software in JuliaNLSolvers
Other
30 stars 28 forks source link

allow using other array types in TwiceOrderDifferentiable finite differences #139

Closed longemen3000 closed 3 years ago

longemen3000 commented 3 years ago

xref https://github.com/JuliaNLSolvers/Optim.jl/issues/924

amrods commented 3 years ago

Is this as easy as changing Vector to AbstractVector and Matrix to AbstractMatrix in https://github.com/JuliaNLSolvers/NLSolversBase.jl/blob/62d2199f70cce78479658da08d346bbc060fc2f7/src/objective_types/twicedifferentiable.jl#L116 and https://github.com/JuliaNLSolvers/NLSolversBase.jl/blob/62d2199f70cce78479658da08d346bbc060fc2f7/src/objective_types/twicedifferentiable.jl#L121 ? If so, I can make that PR. I am needing that relatively quickly.

longemen3000 commented 3 years ago

Yes, it's only that. If you need it right know without waiting for a PR, you can write a junction yourself that does what the Twicedifferentiable.jl constructor do

amrods commented 3 years ago

I'll do that in my fork directly, but I won't make a PR. I don't want to usurp it from you. I am afraid of messing up my packages though. I suppose I can remove the "official" version and instead install my fork.