search

JuliaNLSolvers / NLSolversBase.jl

Base package for optimization and equation solver software in JuliaNLSolvers
Other
30 stars 28 forks source link

relax type requirement on TwiceDifferentiable #140

Closed longemen3000 closed 3 years ago

longemen3000 commented 3 years ago

this relaxation just follows the style present on all the other NDifferentiable functions, fixes https://github.com/JuliaNLSolvers/NLSolversBase.jl/issues/139

pkofod commented 3 years ago

Great, thanks. We just need a test that verifies that it works as intended (say with componentarrays).

amrods commented 3 years ago

can I add those test to this PR?

longemen3000 commented 3 years ago

Of course

amrods commented 3 years ago

how, a fork from your fork?

longemen3000 commented 3 years ago

You can push to my master branch and the changes will appear here (I gave you write access a few moments ago)

amrods commented 3 years ago

Done, let's merge this!

amrods commented 3 years ago

is there anything else needed to merge this PR @pkofod ?

pkofod commented 3 years ago

is there anything else needed to merge this PR @pkofod ?

My attention :) You have it...

pkofod commented 3 years ago

Thanks!