search

JuliaNLSolvers / NLsolve.jl

Julia solvers for systems of nonlinear equations and mixed complementarity problems
Other
329 stars 66 forks source link

Can call to mul! in newton.ls saved ? #245

Closed amartinhuertas closed 3 years ago

amartinhuertas commented 4 years ago

Dear NLsolve.jl developers,

I think that the following call to mul!:

https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/src/solvers/newton.jl#L94

can be saved if linesearch isa Static evaluates to true. Note that cache.g is only consumed in this line:

https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/src/solvers/newton.jl#L119

am I right? Is there anything I am missing?

Thanks! @amartinhuertas

pkofod commented 4 years ago

Sorry, I didn't see this earlier, let me have a look.

pkofod commented 4 years ago

You mean like this right? https://github.com/JuliaNLSolvers/NLsolve.jl/pull/249

amartinhuertas commented 4 years ago

You mean like this right? #249

Yes, indeed! Thanks!

pkofod commented 3 years ago

Sorry I didn't tag this change earlier. Had a thesis to finishing writing and hand in :grimacing: It's merged. I'll tag soon.