JuliaNLSolvers / NLsolve.jl

Julia solvers for systems of nonlinear equations and mixed complementarity problems
Other
324 stars 66 forks source link

Incorrect default in readme #274

Closed jlperla closed 1 year ago

jlperla commented 3 years ago

In https://github.com/JuliaNLSolvers/NLsolve.jl/blob/master/src/nlsolve/nlsolve.jl#L14 it is m=10 instead.

codecov[bot] commented 3 years ago

Codecov Report

Merging #274 (a9ea51e) into master (2196728) will increase coverage by 0.01%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
+ Coverage   87.57%   87.58%   +0.01%     
==========================================
  Files          12       12              
  Lines         531      556      +25     
==========================================
+ Hits          465      487      +22     
- Misses         66       69       +3     
Impacted Files Coverage Δ
src/NLsolve.jl 50.00% <0.00%> (-16.67%) :arrow_down:
src/solvers/broyden.jl 71.73% <0.00%> (-2.99%) :arrow_down:
src/solvers/newton.jl 100.00% <0.00%> (ø)
src/nlsolve/fixedpoint.jl 100.00% <0.00%> (ø)
src/objectives/helpers.jl 100.00% <0.00%> (ø)
src/solvers/trust_region.jl 98.19% <0.00%> (+0.05%) :arrow_up:
src/solvers/anderson.jl 95.00% <0.00%> (+0.26%) :arrow_up:
src/nlsolve/utils.jl 97.56% <0.00%> (+0.26%) :arrow_up:
src/nlsolve/nlsolve.jl 93.10% <0.00%> (+1.10%) :arrow_up:
src/solvers/mcp_func_defs.jl 75.00% <0.00%> (+2.77%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2196728...a9ea51e. Read the comment docs.

pkofod commented 1 year ago

Thanks