JuliaNLSolvers / Optim.jl

Optimization functions for Julia
Other
1.11k stars 213 forks source link

NamedTuple switch broke add_default_options #1041

Closed blegat closed 1 year ago

blegat commented 1 year ago

The change in https://github.com/JuliaNLSolvers/Optim.jl/pull/1026/ broke the following function: https://github.com/JuliaNLSolvers/Optim.jl/blob/f43e6084aacf2dabb2b142952acd3fbb0e268439/src/multivariate/optimize/interface.jl#L21-L27 because iterating over a NamedTuple doesn't give pairs like a Dict. This broke the tests for https://github.com/JuliaNLSolvers/Optim.jl/pull/929 (so if this PR had been merged, it would have detected the failure :innocent: )

pkofod commented 1 year ago

Fixed, thank you .