search

JuliaNLSolvers / Optim.jl

Optimization functions for Julia
Other
1.12k stars 217 forks source link

Add option for disabling warnings #1058

Closed MilesCranmer closed 9 months ago

MilesCranmer commented 10 months ago

This my second attempt at https://github.com/JuliaNLSolvers/Optim.jl/pull/1049. This time I add a new option for configuring this.

@mohamed82008 @pkofod could you please prioritize reviewing and merging one of these? For the past 3 months this has been blocking us from upgrading our ecosystem of symbolic regression tools to the latest version of Optim.jl.

I have kept #1049 open FYI. I'm happy with either one, I just need a way to turn the warnings off, lest PySR's output be overrun with unnecessary warnings.

MilesCranmer commented 9 months ago

Ping @mohamed82008 @pkofod. Sorry for being annoying but I've been waiting for this since August and it is still blocking me from upgrading.

pkofod commented 9 months ago

Ping @mohamed82008 @pkofod. Sorry for being annoying but I've been waiting for this since August and it is still blocking me from upgrading.

not annoying. Your ping to Mohamed managed to make its way through him to me :) I'll look. Thanks

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5fa5d61) 85.29% compared to head (5232f22) 84.94%. Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1058 +/- ## ========================================== - Coverage 85.29% 84.94% -0.35% ========================================== Files 43 44 +1 Lines 3216 3427 +211 ========================================== + Hits 2743 2911 +168 - Misses 473 516 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MilesCranmer commented 9 months ago

Thanks again for merging this @pkofod!

I was wondering if you or @mohamed82008 might be able to trigger a release so I can update my dependencies?

pkofod commented 8 months ago

I'll tag a new release, yes