Open blegat opened 5 months ago
Attention: Patch coverage is 93.33333%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 85.75%. Comparing base (
01b9391
) to head (c43736e
).:exclamation: Current head c43736e differs from pull request most recent head 1d9aabb. Consider uploading reports for the commit 1d9aabb to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/MOI_wrapper.jl | 93.33% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I suggesting investigating the remaining failing tests in separate PRs
@pkofod This PR is good to go from my end
@pkofod This PR is good to go from my end
thanks I will look. Busy feb and march for me 😓
Thanks, I just rebased to fix conflicts
As highlighted in https://github.com/JuliaNLSolvers/Optim.jl/issues/1071, most tests were failing because the starting point was infeasible. With this PR, most are now passing. The remaining ones to investigate are:
test_nonlinear_expression_hs071
: this one gives an infeasible solution, not sure if it's due to the fact that the starting values does not satisfy the constraints, no warning is thrown though.test_nonlinear_expression_hs071_epigraph
: the variables are in the interior of the bounds but some of the constraints are not satisfied hence the warning is thrown. Then it converges to an incorrect solutiontest_objective_FEASIBILITY_SENSE_clears_objective
: this one seems it may be a bug in the MOI wrapper, let me investigate first