JuliaNLSolvers / Optim.jl

Optimization functions for Julia
Other
1.1k stars 214 forks source link

Start in interior of variable bounds #1073

Open blegat opened 5 months ago

blegat commented 5 months ago

As highlighted in https://github.com/JuliaNLSolvers/Optim.jl/issues/1071, most tests were failing because the starting point was infeasible. With this PR, most are now passing. The remaining ones to investigate are:

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.75%. Comparing base (01b9391) to head (c43736e).

:exclamation: Current head c43736e differs from pull request most recent head 1d9aabb. Consider uploading reports for the commit 1d9aabb to get more accurate results

Files Patch % Lines
src/MOI_wrapper.jl 93.33% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1073 +/- ## ========================================== + Coverage 85.46% 85.75% +0.29% ========================================== Files 45 46 +1 Lines 3274 3511 +237 ========================================== + Hits 2798 3011 +213 - Misses 476 500 +24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blegat commented 5 months ago

I suggesting investigating the remaining failing tests in separate PRs

blegat commented 4 months ago

@pkofod This PR is good to go from my end

pkofod commented 3 months ago

@pkofod This PR is good to go from my end

thanks I will look. Busy feb and march for me 😓

blegat commented 3 months ago

Thanks, I just rebased to fix conflicts