`limits_box` function in `fminbox.jl` is unused. Can it be removed?

JuliaNLSolvers / Optim.jl

Optimization functions for Julia

Other

1.13k stars 221 forks source link

`limits_box` function in `fminbox.jl` is unused. Can it be removed? #982

Open nhz2 opened 2 years ago

nhz2 commented 2 years ago

From what I can tell https://github.com/JuliaNLSolvers/Optim.jl/blob/89b6804badaf49e4df1a54da0b9378507f7aa583/src/multivariate/solvers/constrained/fminbox.jl#L152 isn't being used anywhere. Can this function be deleted?

pkofod commented 2 years ago

I have to look back at the history to figure out why it isn't used. I think it's a mistake. I think it used to be used to set alphamax for fminbox+cgdescent (now HagerZhang), but it seems to have been lost somewhere along the way.