search

JuliaNeuroscience / NIfTI.jl

Julia module for reading/writing NIfTI MRI files
Other
74 stars 34 forks source link

Assert that extension size is divisible by 16 #62

Open azraq27 opened 2 years ago

azraq27 commented 2 years ago

The current implementation of esize makes an @assert check that the size is not divisible by 16, which I believe is the opposite of what is intended.

Minimal example:

dset = niread(fname)
ex = dset.extensions[1]
NIfTI.esize(ex)

AssertionError: NIfTIExtension has innapropriate size. See docstrings for more details.

codecov[bot] commented 2 years ago

Codecov Report

Merging #62 (bdad34e) into master (06d4ce3) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   52.27%   52.27%           
=======================================
  Files           6        6           
  Lines         549      549           
=======================================
  Hits          287      287           
  Misses        262      262
Impacted Files Coverage Δ
src/extensions.jl 15.78% <0.00%> (ø)

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more