search

JuliaORNL / JACC.jl

CPU/GPU parallel performance portable layer in Julia via functions as arguments
MIT License
21 stars 13 forks source link

Fix precompilation #52

Closed michel2323 closed 7 months ago

michel2323 commented 7 months ago

This fixes the precompilation when using an extension for CUDA, ROCm, or oneAPI, by specializing the methods and not overwriting them.

williamfgc commented 7 months ago

Test this please

michel2323 commented 7 months ago

@williamfgc Can you rerun?

michel2323 commented 7 months ago

Test this please

michel2323 commented 7 months ago

Ok, that bot doesn't listen to me :-).

williamfgc commented 7 months ago

Test this please

michel2323 commented 7 months ago

The MacOS one seems to be a CI issue.

williamfgc commented 7 months ago

Test this please

williamfgc commented 7 months ago

@Geekdude do you know if cousteau is up? I couldn't run CI. Thanks! @michel2323 yes, the macos error is related to brew update.

Geekdude commented 7 months ago

Test this please

Geekdude commented 7 months ago

@michel2323 @williamfgc Looks like I got the tests running again on Cousteau, but the test is failing.

michel2323 commented 7 months ago

@williamfgc Glad there's a CI. I had a typo that I only fixed in CUDA. Aaand a rerun please :-) .

williamfgc commented 7 months ago

Test this please

michel2323 commented 7 months ago

@Geekdude I think this is the CI failing. Something with ROCm 6.0.

williamfgc commented 7 months ago

Test this please

williamfgc commented 7 months ago

@michel2323 can you rebase main and push force this branch? I am trying a generic rocm module.

michel2323 commented 7 months ago

@williamfgc Rebased and squashed into one commit.

williamfgc commented 7 months ago

Test this please

Geekdude commented 7 months ago

@michel2323, Steve updated the ROCM version on Cousteau to rocm/6.0.2. Since only one working version will be deployed (different versions of ROCM don't play nice with each other), I will update the CI to load the latest ROCM instead of a specific version.

Geekdude commented 7 months ago

Test this please

Geekdude commented 7 months ago

Looks like there is still an error, but it is no longer erroring on the module load.

michel2323 commented 7 months ago

This should work now. Ran the tests on an AMD GPU.

Geekdude commented 7 months ago

Test this please

williamfgc commented 7 months ago

Thanks @Geekdude and @michel2323 for taking care of CI issues. I will merge, the macos error is way upstream.