search

JuliaObjects / Accessors.jl

Update immutable data
Other
175 stars 19 forks source link

Fix Errors in extensions during precompilation #127 #128

Closed jw3126 closed 9 months ago

jw3126 commented 9 months ago

This reverts https://github.com/JuliaObjects/Accessors.jl/pull/121 We can reactivate it when the bug is fixed on mainstream julia versions.

Fix #127

jw3126 commented 9 months ago

@aplavin LGTY?

aplavin commented 9 months ago

Not at the computer with git and ide right now, cannot correct myself. I think the smallest change is just to change Project.toml as you did, and remove if here https://github.com/JuliaObjects/Accessors.jl/blob/768e71887e1ea56bf9f0acff52cd33b79438b50a/src/Accessors.jl#L23 so that includes are always executed. Keeping all other files intact. This will keep the separation for the future.

jw3126 commented 9 months ago

I tried that first, but julia still complains, they are also listed in Project.toml as extensions etc. So it is multiple places to edit. So I think it is better to revert and later we can resurrect the full commit.

aplavin commented 9 months ago

Tried to make a PR with github web interface, but accidentally made an actual commit, sorry for that... Should work I think, let's wait for test.

jw3126 commented 9 months ago

Well okay that is also fine I guess.