JuliaObjects / Accessors.jl

Update immutable data
Other
177 stars 19 forks source link

Tests fail on 1.11 #147

Closed KristofferC closed 1 week ago

KristofferC commented 6 months ago

(Same as https://github.com/jw3126/Setfield.jl/issues/179)

IR: Test Failed at /home/pkgeval/.julia/packages/Accessors/81CPQ/test/perf.jl:92
  Expression: uniquecounts(heads_lens) == uniquecounts(heads_hand)
   Evaluated: Dict(:call => 9, :new => 1) == Dict(:call => 3, :new => 1)

Stacktrace:
 [1] macro expansion
   @ /opt/julia/share/julia/stdlib/v1.11/Test/src/Test.jl:679 [inlined]
 [2] test_ir_lens_vs_hand(info_lens::Core.CodeInfo, info_hand::Core.CodeInfo)
   @ Main.Perf ~/.julia/packages/Accessors/81CPQ/test/perf.jl:92
 [3] macro expansion
   @ ~/.julia/packages/Accessors/81CPQ/test/perf.jl:139 [inlined]
 [4] macro expansion
   @ /opt/julia/share/julia/stdlib/v1.11/Test/src/Test.jl:1700 [inlined]
 [5] macro expansion
   @ ~/.julia/packages/Accessors/81CPQ/test/perf.jl:137 [inlined]
 [6] macro expansion
   @ /opt/julia/share/julia/stdlib/v1.11/Test/src/Test.jl:1789 [inlined]
 [7] top-level scope
   @ ~/.julia/packages/Accessors/81CPQ/test/perf.jl:121
aplavin commented 6 months ago

Which 1.11 version specifically? I ran tests on github actions for several versions, and both 1.11s fail with a different error:

@accessor: Test Failed at /home/runner/work/Accessors.jl/Accessors.jl/test/test_core.jl:604
  Expression: strip(string(#= /home/runner/work/Accessors.jl/Accessors.jl/test/test_core.jl:604 =# @doc(my_x))) == "Documentation for my_x"
   Evaluated: "nothing" == "Documentation for my_x"

For some reason, @doc ... seems to return nothing instead of the docstring – not sure if a known regression or not. Anyway, different error from what you show.

See full test run at https://github.com/aplavin/Accessors.jl/actions/runs/8782924455/job/24098041340.

KristofferC commented 6 months ago

I ran tests on github actions for several versions, and both 1.11s fail with a different error:

That is known: https://github.com/JuliaLang/julia/issues/52986.

The error for this comes from PkgEval on the backport branch: https://s3.amazonaws.com/julialang-reports/nanosoldier/pkgeval/by_hash/bdc7fb7_vs_bd47eca/Accessors.primary.log

aplavin commented 1 week ago

Tests pass now, after https://github.com/JuliaObjects/Accessors.jl/pull/175. The issue from your first message here didn't manifest itself in the end, only the @doc regression :)