search

JuliaOpt / CoinOptServices.jl

Julia interface to COIN-OR Optimization Services https://projects.coin-or.org/OS
Other
16 stars 4 forks source link

Handle changes to comparison parsing in Julia 0.5. Fixes #16 #17

Closed JackDunnNZ closed 8 years ago

JackDunnNZ commented 8 years ago

I copied over the changes from AmplNLWriter.jl that were needed to fix the comparison changes as per #16. The situation after the change with the comparison and binary operator dicts isn't that nice, but eventually the comparison one (and associated special casing) will go away I guess. Feel free to build on top of this if you wanted to do anything differently.

JackDunnNZ commented 8 years ago

The non-linear tests are passing locally, not sure what CI will say since it's trying to run all of the JuMP tests

JackDunnNZ commented 8 years ago

Sorry, I've been busy and haven't had the chance to finish this off. I can get to it early next week, but I think the only thing still to be done here is adding the specific version number to the cutoffs?

mlubin commented 8 years ago

Bump. Would be nice to get CointOptServices working on 0.5.

JackDunnNZ commented 8 years ago

All it needs is to add the more specific version tags. I can add them if someone tells me what to add.

mlubin commented 8 years ago

Don't really see the point in keeping the package broken on 0.5 for everyone just so that we can support now very old versions of 0.5. @tkelman?

tkelman commented 8 years ago

v"0.5.0-dev+3231"

JackDunnNZ commented 8 years ago

Updated to use the specific version. Failures seem unrelated to this change, but I could be wrong

tkelman commented 8 years ago

MIQP vectorization failures are known. Looks like JuMP has some ambiguities though.

mlubin commented 8 years ago

Looks like JuMP has some ambiguities though.

Those are fixed in JuMP master.

mlubin commented 8 years ago

If things pass (modulo expected failures) on Julia 0.5 with JuMP master then should be safe to merge and tag.

mlubin commented 8 years ago

@tkelman, may I tag?

tkelman commented 8 years ago

yes go ahead

mlubin commented 8 years ago

May need to wait till tomorrow for some debugging, just tried to build the package and got nasty errors.