Created CITATION.bib - Githubissues

JuliaOptimalTransport / OptimalTransport.jl

Optimal transport algorithms for Julia

https://juliaoptimaltransport.github.io/OptimalTransport.jl/dev

MIT License

94 stars 8 forks source link

Created CITATION.bib #107

Closed davibarreira closed 3 years ago

davibarreira commented 3 years ago

I've created this CITATION.bib file, so that our package works with the new PkgCite.jl package. We should probably automatize the process of updating this CITATION.bib file, by pulling it from Zenodo (which is what I did manually).

davibarreira commented 3 years ago

By the way, I think I actually don't have the privileges to create a workflow on Actions in order to make this process automatic.

devmotion commented 3 years ago

By the way, I think I actually don't have the privileges to create a workflow on Actions in order to make this process automatic.

One just has to add a file in .github/workflows, there's no special permission needed.

davibarreira commented 3 years ago

By the way, I think I actually don't have the privileges to create a workflow on Actions in order to make this process automatic.

One just has to add a file in .github/workflows, there's no special permission needed.

Thanks, I didn't know. Thought I had to do it via GitHub Actions interface.

devmotion commented 3 years ago

BTW I am not sure if the Zenodo reference should/has to be added here. It seems the goal is that it is retrieved automatically from the README which would always be the most recent version and avoid this redundancy: https://github.com/SebastianM-C/PkgCite.jl/issues/1

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 949725256

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.672%

Totals
Change from base Build 928044156:	0.0%
Covered Lines:	462
Relevant Lines:	488

💛 - Coveralls

davibarreira commented 3 years ago

Oh, I see. So the Zenodo integration is still on progress. I think it's better to wait for that then. I'll close this PR. Thanks

devmotion commented 3 years ago

To me this seems to be a better idea than trying to keep the reference uptodate. Updating it with Github actions e.g. if a new tag is created seems cumbersome and then the updated CITATION.bib for version 3.11 would only be part of 3.12 (since it is created after 3.11 is released). This seems strange.

davibarreira commented 3 years ago

I'll see if I can perhaps contribute with the PkgCite to get the citation from zenode ;)

davibarreira commented 3 years ago

I've submitted a PR to PkgCite to get badges from Zenodo. I'm just working on some modifications proposed by the author, but in a day or two everything should be up and running :D

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 949725256

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.672%

Totals
Change from base Build 928044156:	0.0%
Covered Lines:	462
Relevant Lines:	488