JuliaOptimalTransport / OptimalTransport.jl

Optimal transport algorithms for Julia
https://juliaoptimaltransport.github.io/OptimalTransport.jl/dev
MIT License
93 stars 8 forks source link

Quad gpu fix #121

Closed zsteve closed 2 years ago

zsteve commented 2 years ago

This PR fixes type issues that prevent quadreg from running with CuArrays, and adds a test for that setting. Also fixes a bug with the Armijo step search which I found for certain inputs caused the solver to get stuck.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1176317897


Totals Coverage Status
Change from base Build 1174249145: 0.02%
Covered Lines: 671
Relevant Lines: 687

💛 - Coveralls
codecov-commenter commented 2 years ago

Codecov Report

Merging #121 (22b4f92) into master (d33f1cf) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   97.65%   97.67%   +0.01%     
==========================================
  Files          13       13              
  Lines         682      687       +5     
==========================================
+ Hits          666      671       +5     
  Misses         16       16              
Impacted Files Coverage Δ
src/quadratic_newton.jl 98.16% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d33f1cf...22b4f92. Read the comment docs.