JuliaOptimalTransport / OptimalTransport.jl

Optimal transport algorithms for Julia
https://juliaoptimaltransport.github.io/OptimalTransport.jl/dev
MIT License
93 stars 8 forks source link

Update dependencies and CI #158

Closed devmotion closed 2 years ago

devmotion commented 2 years ago

This PR updates ExactOptimalTransport and Tulip dependencies and CI.

Fixes https://github.com/JuliaOptimalTransport/OptimalTransport.jl/pull/156, https://github.com/JuliaOptimalTransport/OptimalTransport.jl/pull/155, https://github.com/JuliaOptimalTransport/OptimalTransport.jl/pull/154.

devmotion commented 2 years ago

Test failures are probably just random failures caused by the RNG changes in 1.7. I'll check it.

devmotion commented 2 years ago

Hmm I can't reproduce the error locally, possibly only an architecture dependent floating point issue.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 1613454704

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1396217363: 0.1%
Covered Lines: 605
Relevant Lines: 634

💛 - Coveralls
codecov-commenter commented 2 years ago

Codecov Report

Merging #158 (3c8b428) into master (40a1808) will increase coverage by 0.11%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   95.31%   95.42%   +0.11%     
==========================================
  Files          14       14              
  Lines         619      634      +15     
==========================================
+ Hits          590      605      +15     
  Misses         29       29              
Impacted Files Coverage Δ
src/quadratic.jl 100.00% <0.00%> (ø)
src/entropic/sinkhorn.jl 100.00% <0.00%> (ø)
src/entropic/sinkhorn_gibbs.jl 100.00% <0.00%> (ø)
src/entropic/sinkhorn_stabilized.jl 100.00% <0.00%> (ø)
src/entropic/sinkhorn_barycenter_gibbs.jl 100.00% <0.00%> (ø)
src/entropic/sinkhorn_epsscaling.jl 95.34% <0.00%> (+0.11%) :arrow_up:
src/entropic/symmetric.jl 96.61% <0.00%> (+0.18%) :arrow_up:
src/utils.jl 95.55% <0.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40a1808...3c8b428. Read the comment docs.

devmotion commented 2 years ago

I have no idea what causes the OpenBLAS error with Julia 1.7 on Windows: https://github.com/JuliaOptimalTransport/OptimalTransport.jl/runs/4612478949?check_suite_focus=true#step:8:190 Interestingly, Julia nightly seems to work on Windows.

devmotion commented 2 years ago

It seems the problem was caused by the OpenBLAS issues in base that were fixed in Julia 1.6.5 and 1.7.1.