JuliaOptimalTransport / OptimalTransport.jl

Optimal transport algorithms for Julia
https://juliaoptimaltransport.github.io/OptimalTransport.jl/dev
MIT License
93 stars 8 forks source link

remove deprecation tests in attempt to fix CI #171

Closed zsteve closed 1 year ago

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 2900367433

Details


Files with Coverage Reduction New Missed Lines %
src/entropic/sinkhorn_unbalanced.jl 3 94.12%
<!-- Total: 3 -->
Totals Coverage Status
Change from base Build 2897651829: -0.4%
Covered Lines: 646
Relevant Lines: 681

💛 - Coveralls
codecov-commenter commented 1 year ago

Codecov Report

Merging #171 (a38bad1) into master (9da044c) will decrease coverage by 0.44%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   95.30%   94.86%   -0.45%     
==========================================
  Files          14       14              
  Lines         681      681              
==========================================
- Hits          649      646       -3     
- Misses         32       35       +3     
Impacted Files Coverage Δ
src/entropic/sinkhorn_unbalanced.jl 94.11% <0.00%> (-2.95%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

zsteve commented 1 year ago

It looks like for certain versions of Julia on Windows, POT/PythonOT failing to converge triggers some kind of memory error. I've not been able to reproduce this on any of my Linux machines. This is likely something upstream to do with PyCall.

zsteve commented 1 year ago

looks like the ReadOnlyMemoryError happens regardless of the convergence warnings. Will need to investigate further.