search

JuliaPOMDP / BasicPOMCP.jl

The PO-UCT algorithm (aka POMCP) implemented in Julia
Other
35 stars 17 forks source link

Towards honoring action(m, x) #11

Closed lassepe closed 5 years ago

lassepe commented 5 years ago

In an effort to take a step towards fixing JuliaPOMDP/POMDPs.jl#226 I made BasicPOMCP use POMDPs.actions(pomdp, b).BasicPOMCP will now call this function with b being either the root belief or a POMCPObsNode in similar fashion as POMCPOW does already.

In order to provide a shared interface for both POMCPObsNode and POWTreeObsNode I moved

to BasicPOMCP. I will file a pull request for POMCPOW to use these functions.

This is probably only an intermediate solution to this problem. @zsunberg suggested that maybe later POMDPs.jl should specify the existence of history(b) to access the history for belief types that have a notion of this history.

Edit: Maybe current_obs and isroot are rather something that should be moved to MCTS? I just noticed that MCTS also provides isroot.

codecov-io commented 5 years ago

Codecov Report

Merging #11 into master will increase coverage by 7.95%. The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   47.11%   55.07%   +7.95%     
==========================================
  Files           6        6              
  Lines         208      207       -1     
==========================================
+ Hits           98      114      +16     
+ Misses        110       93      -17
Impacted Files Coverage Δ
src/visualization.jl 42.1% <ø> (+13.15%) :arrow_up:
src/solver.jl 64.28% <100%> (ø) :arrow_up:
src/BasicPOMCP.jl 52.77% <28.57%> (-2.07%) :arrow_down:
src/requirements_info.jl 73.52% <50%> (+20.4%) :arrow_up:
src/rollout.jl 34.61% <0%> (+2.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf862ef...2f37667. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #11 into master will increase coverage by 7.95%. The diff coverage is 41.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   47.11%   55.07%   +7.95%     
==========================================
  Files           6        6              
  Lines         208      207       -1     
==========================================
+ Hits           98      114      +16     
+ Misses        110       93      -17
Impacted Files Coverage Δ
src/visualization.jl 42.1% <ø> (+13.15%) :arrow_up:
src/solver.jl 64.28% <100%> (ø) :arrow_up:
src/BasicPOMCP.jl 52.77% <28.57%> (-2.07%) :arrow_down:
src/requirements_info.jl 73.52% <50%> (+20.4%) :arrow_up:
src/rollout.jl 34.61% <0%> (+2.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cf862ef...2f37667. Read the comment docs.

zsunberg commented 5 years ago

Not sure if we should merge this or fix https://github.com/JuliaPOMDP/POMDPs.jl/issues/226

lassepe commented 5 years ago

I guess fixing JuliaPOMDPs/POMDPs.jl#226 is the right thing to do. I will close this PR but keep the branch because for me it is a useful fix for now.