JuliaPOMDP / BasicPOMCP.jl

The PO-UCT algorithm (aka POMCP) implemented in Julia
Other
35 stars 17 forks source link

Support belief dependent action spaces #12

Closed lassepe closed 4 years ago

lassepe commented 4 years ago

Open questions:

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 83.784% when pulling 80668b46e4aa9abd708eb51832adecd70f60e96d on actions-mb into e17df32db170ac96542d669b3c452a025f3f9508 on master.

codecov[bot] commented 4 years ago

Codecov Report

Merging #12 into master will increase coverage by 0.26%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
+ Coverage   83.51%   83.78%   +0.26%     
==========================================
  Files           6        6              
  Lines         182      185       +3     
==========================================
+ Hits          152      155       +3     
  Misses         30       30
Impacted Files Coverage Δ
src/requirements_info.jl 95% <100%> (ø) :arrow_up:
src/BasicPOMCP.jl 96.77% <100%> (+0.34%) :arrow_up:
src/solver.jl 93.93% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e17df32...80668b4. Read the comment docs.

zsunberg commented 4 years ago

should AOHistoryBelief contain more information?

I think this is good for now - thanks! Maybe one day there could be a way to access history from further back up the tree (e.g. if certain actions can never be used twice or something), but I don't think that's a top priority right now.