search

JuliaPOMDP / BasicPOMCP.jl

The PO-UCT algorithm (aka POMCP) implemented in Julia
Other
35 stars 17 forks source link

FOValue using underlying mdp #25

Closed WhiffleFish closed 3 years ago

WhiffleFish commented 3 years ago

solve(::ValueIterationSolver, ::POMDP) is no longer supported.

Extract underlying MDP for VI compatibility.

zsunberg commented 3 years ago

Thanks @WhiffleFish looks good! Normally it would be good to add a test that fails before the fix and passes after the fix, but it seems like in this case that would introduce a dependency on DiscreteValueIteration

zsunberg commented 3 years ago

@WhiffleFish are there any other changes coming up, or should I tag a new version of this?

WhiffleFish commented 3 years ago

@zsunberg Ideally I'd like to make it such that value estimation for non-AbstractPOMCP solvers is achievable without copy-pasting methods and making small changes, but I don't see a clear way to do that currently, so I'd say it's safe to tag a new version.