JuliaPOMDP / BasicPOMCP.jl

The PO-UCT algorithm (aka POMCP) implemented in Julia
Other
35 stars 17 forks source link

Wrong Available Actions when adding Obs Node #34

Closed LorenzoBonanni closed 1 year ago

LorenzoBonanni commented 1 year ago

I'm trying to use BasicPOMCP with the RockSample Environment. When adding a new obs node in BasicPOMCP.jl at row 180 the environment will return all available actions instead of only the legal action for the current state. The problem comes from the fact that when calling the actions function POMCP is passing the pomdp and LeafNodeBelief but since the environment does not implement any function to handle LeafNodeBelief will return all available actions.

I'm not sure if this issue should be fixed here or in the RockSample environment, I thought to open the issue here since LeafNodeBelief is a structure specific to this package and the environment should be as generic as possible. A quick fix might be to give only pomdp and the state to the actions function

LorenzoBonanni commented 1 year ago

Nevermind I've found a way to fix this into the environment