search

JuliaPOMDP / DiscreteValueIteration.jl

Value iteration solver for MDPs
Other
20 stars 12 forks source link

Use SparseTabularMDP from POMDPModelTools #32

Closed MaximeBouton closed 5 years ago

MaximeBouton commented 5 years ago

TODO: add a warning for POMDPs?

MaximeBouton commented 5 years ago

Restart travis after JuliaRegistries/General#2643 gets merged

MaximeBouton commented 5 years ago

The build fails in 0.7, I think we can safely drop the support. Any objections @zsunberg @rejuvyesh ?

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@95f407d). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   97.72%           
=========================================
  Files             ?        4           
  Lines             ?      132           
  Branches          ?        0           
=========================================
  Hits              ?      129           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
src/sparse.jl 90.9% <100%> (ø)
src/vanilla.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95f407d...e739781. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@95f407d). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   97.72%           
=========================================
  Files             ?        4           
  Lines             ?      132           
  Branches          ?        0           
=========================================
  Hits              ?      129           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
src/sparse.jl 90.9% <100%> (ø)
src/vanilla.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95f407d...e739781. Read the comment docs.

mykelk commented 5 years ago

Sounds good to me.

zsunberg commented 5 years ago

The build fails in 0.7, I think we can safely drop the support. Any objections @zsunberg @rejuvyesh ?

drop it!