search

JuliaPOMDP / POMDPModels.jl

Problem models for testing POMDPs.jl
Other
31 stars 28 forks source link

New gridworld #50

Closed zsunberg closed 6 years ago

zsunberg commented 6 years ago

This includes visualization, so waiting on JuliaPOMDP/POMDPModelTools#7 and https://github.com/GiovineItalia/Compose.jl/issues/297

Maybe I will submit another PR without the visualization first.

zsunberg commented 6 years ago

Compose visualization for SimpleGridWorld is supported via Requires.jl for now.

Any comments @MaximeBouton , @rejuvyesh ? I'll probably merge this tonight

codecov-io commented 6 years ago

Codecov Report

Merging #50 into master will increase coverage by 2.61%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   90.37%   92.98%   +2.61%     
==========================================
  Files           8       11       +3     
  Lines         187      271      +84     
==========================================
+ Hits          169      252      +83     
- Misses         18       19       +1
Impacted Files Coverage Δ
src/TMazes.jl 88.73% <ø> (ø)
src/legacy/GridWorlds.jl 89.33% <100%> (ø)
src/gridworld.jl 100% <100%> (ø)
src/POMDPModels.jl 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 855c671...b050b7f. Read the comment docs.

MaximeBouton commented 6 years ago

Looks very nice! thanks