search

JuliaPOMDP / POMDPModels.jl

Problem models for testing POMDPs.jl
Other
31 stars 28 forks source link

TMaze bugfix: terminal states #58

Closed mattuntergassmair closed 4 years ago

mattuntergassmair commented 4 years ago

Discovered several problems when running test set from SparseTabularPOMDP in POMDPModelTools.jl.

For some reason, stateindex and pdf are called with an argument of type Tuple{TMazeState, Float64} in test/test_tabular.jl (POMDPModelTools.jl) and I was not able to track down where that call was initiated from. I temporarily added two functions that satisfy this interface, but they should probably be removed again before this issue is closed.

I think the transition matrix violates the assumption that a terminal state cannot be escaped (check conditions based on d.reset in the transition function)

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.2%) to 65.666% when pulling 75df3c83633c556e12a4b90259842e685ef20224 on mattuntergassmair:master into 77d6e96e05a941de65c87a1d86ad8f3c8f6e4450 on JuliaPOMDP:master.

rejuvyesh commented 4 years ago

Not many people seem to use TMaze so it has coderotted a bit.

zsunberg commented 4 years ago

@mattuntergassmair Thanks a bunch!! We should not have that Tuple{TMazeState, Float64} call. I will track it down

mattuntergassmair commented 4 years ago

@mattuntergassmair Thanks a bunch!! We should not have that Tuple{TMazeState, Float64} call. I will track it down

Thanks, that would be great! For some reason the stacktrace for those calls didn't seem to be super useful so I couldn't find out what was going on under the hood.

zsunberg commented 4 years ago

Ok, I think this is fine to merge as soon as the tests pass