search

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.
http://juliapomdp.github.io/POMDPs.jl/latest/
Other
671 stars 105 forks source link

Version 0.9 #307

Closed zsunberg closed 4 years ago

zsunberg commented 4 years ago

This branch will currently

codecov[bot] commented 4 years ago

Codecov Report

Merging #307 into master will increase coverage by 1.60%. The diff coverage is 93.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   81.72%   83.33%   +1.60%     
==========================================
  Files          14        9       -5     
  Lines         509      114     -395     
==========================================
- Hits          416       95     -321     
+ Misses         93       19      -74
Impacted Files Coverage Δ
src/POMDPs.jl 100.00% <ø> (ø)
src/belief.jl 50.00% <ø> (ø)
src/pomdp.jl 85.71% <ø> (ø)
src/space.jl 0.00% <ø> (ø)
src/gen_impl.jl 93.47% <91.17%> (+2.36%) :arrow_up:
src/deprecated.jl 96.15% <96.15%> (+36.15%) :arrow_up:
src/generative.jl 100.00% <100.00%> (ø)
src/utils.jl 28.57% <100.00%> (-32.30%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fea17ec...143851a. Read the comment docs.

zsunberg commented 4 years ago

To keep track of fixes that this branch currently has, it will currently

zsunberg commented 4 years ago

Ok, I think this is ready to merge and release. The solvers and models will have to be updated afterwards, but I think this will be nearly all find-and-replace (see #312 and #313). I have already updated some of the packages and it has been straightforward, and I think nearly all models and solvers compatible with POMDPs 0.8 will run in POMDPs 0.9 with deprecation warnings.

I know people are busy right now, so not expecting a ton of feedback, but any is welcome! I have requested "reviews" from @MaximeBouton, @rejuvyesh, and @lassepe , but I am really just looking for any broad questions and concerns before merging this - you only need to do a detailed low level code review if you really want to :)

I'll wait until next week for any comments and then merge and register this and start on package upgrades.

lassepe commented 4 years ago

You may want so add your "fix list" above to the pr description so that these issues get closed automatically on merge. I think it does not work if you mention them in a comment.