search

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.
http://juliapomdp.github.io/POMDPs.jl/latest/
Other
671 stars 105 forks source link

[WIP] CommonRLInterface Integration #325

Closed zsunberg closed 4 years ago

zsunberg commented 4 years ago

Here is the first step of integration with CommonRLInterface.jl.

What does everyone think? Does this belong in the POMDPs package?

codecov[bot] commented 4 years ago

Codecov Report

Merging #325 into master will increase coverage by 1.72%. The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #325      +/-   ##
==========================================
+ Coverage   81.96%   83.68%   +1.72%     
==========================================
  Files           8        9       +1     
  Lines         122      141      +19     
==========================================
+ Hits          100      118      +18     
- Misses         22       23       +1
Impacted Files Coverage Δ
src/POMDPs.jl 100.00% <ø> (ø)
src/common_rl.jl 89.47% <89.47%> (ø)
src/space.jl 50.00% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d34d217...2da94cb. Read the comment docs.

zsunberg commented 4 years ago

Actually, I'm kind of thinking that this should go in POMDPModelTools

rejuvyesh commented 4 years ago

Yeah POMDPModelTools makes sense too. Best to avoid dependencies here.

zsunberg commented 4 years ago

Ok, moving to POMDPModelTools