search

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.
http://juliapomdp.github.io/POMDPs.jl/latest/
Other
662 stars 100 forks source link

Remove remnants of Travis #363

Closed zsunberg closed 8 months ago

zsunberg commented 3 years ago

We need to go through and remove all .travis.yml files and travis badges. This would be easy to do - just need a volunteer to do it.

dylan-asmar commented 2 years ago

@zsunberg is there a particular workflow preference you have when we update this? In SARSOP.jl, I added separate workflows for documentation and code coverage of tests. I don't mind making similar changes as I come across different repos, but wanted to make sure that separate GitHub actions are ok or if you prefer one large workflow.

zsunberg commented 2 years ago

@dylan-asmar awesome! thanks for your work in SARSOP!

I tend to try to follow what PkgTemplates does, just because that will be the most common thing for the community. Looks like they have it in one file: https://github.com/invenia/PkgTemplates.jl/blob/master/templates/github/workflows/CI.yml

zsunberg commented 2 years ago

If you wanted to get really fancy and really embody the CS virtue of lazyness, you could write a script to do this for all the packages (possibly using the gh command line tool, but I don't think that is strictly needed).

dylan-asmar commented 2 years ago

Making some progress:

Not planning on modifying deprecated packages (e.g. https://github.com/JuliaPOMDP/RLInterface.jl)

zsunberg commented 2 years ago

Awesome, @dylan-asmar , this is really great!

mykelk commented 8 months ago

Thanks so much @dylan-asmar ! I think you can merge these when ready.

zsunberg commented 8 months ago

Yeah, at this point, @dylan-asmar , I think you can just go ahead and merge all pull requests that you have yourself. Just make sure tests pass, etc. The only reason not to would be if you have specific questions that you're not sure how to answer.

Do you have the necessary github permissions to do that?

dylan-asmar commented 8 months ago

I believe I have the permissions. As I'm going through the repos I'm also making minor changes from time to time. I'll ping you @zsunberg on those to just make sure it doesn't mess something up.

dylan-asmar commented 8 months ago

For https://github.com/JuliaPOMDP/POMDPGallery.jl and https://github.com/JuliaPOMDP/POMDPExamples.jl, what are the thoughts on updating these repos with https://github.com/JuliaPOMDP/POMDPs.jl/issues/241 and https://github.com/JuliaPOMDP/POMDPs.jl/issues/417 still open?

zsunberg commented 8 months ago

I don't think we should maintain POMDPExamples. The important tutorials there should be moved to the main POMDPs.jl documentation (i.e. I still think we should fix #417).

I'm less sure about POMDPGallery. I guess since we list the problem repos in the POMDPs.jl README now, the best thing would be to move the examples from POMDPGallery to the individual project repos, but I am not 100% sure.

But that is a lot of work that is probably not the highest priority. If someone can do it, great! but it is not a disaster in the state it is in now.

mykelk commented 8 months ago

I think we should keep POMDPGallery. I use it quite a bit when demoing POMDPs.jl. I'm okay with POMDPExamples eventually being merged into the documentation of POMDPs.jl.

dylan-asmar commented 8 months ago

I think POMDPGallery is a great tool to show off POMDPs.jl. However, I think existing as a separate package doesn't add a lot of value. I think it would be better to have it as part of the docs of POMDPs.jl.

One option would be to have the scripts as examples and then the gifs get created at documentation generation. Another option is to just embed the gifs into the docs and make sure we update them at each new release of POMDPs.jl.

An alternative thought is to create a GitHub action with the problem repos where when updates to the problems occur, it autogenerates the gifs and submits a PR to this POMDPGallery repo.

mykelk commented 8 months ago

I'm good with moving them into the docs. I'd really like to make it easy for people to find a page with all of these examples. If in the docs, then I think we should link directly to that location from the readme.md.

dylan-asmar commented 8 months ago

If we agree to not update POMDPExamples and POMPGallery (move both to docs), then I think this issue is almost ready to be closed out.

The only repo that I think is left is POMDPLinter.jl. When updating that one, I ran into an issue where tests were failing (without updates). I opened an issue on that repo and once we address that issue we can merge the travis_cleanup_ci_updates branch.

@zsunberg , can you take a look at the issue on POMDPLinter.jl and provide any feedback/guidance? I don't mind making changes, but I wasn't sure if I was missing something there.

Is anybody aware of another repo that might have slipped by me and is still using Tavis-CI vs GitHub actions?

dylan-asmar commented 8 months ago

I think we are finally complete with this one. If there are other repos that need to be addressed, please re-open this issue.