Transition from `LightGraphs.jl` to `Graphs.jl`

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.

http://juliapomdp.github.io/POMDPs.jl/latest/

Other

657 stars 100 forks source link

Transition from `LightGraphs.jl` to `Graphs.jl` #424

Closed vancleve closed 1 year ago

vancleve commented 1 year ago

It seems like there isn't much code in POMDPs.jl that relies on LightGraphs.jl: https://github.com/JuliaPOMDP/POMDPs.jl/blob/c4ce1190eddb1b0a23998b1843932465f88bf9ab/src/gen_impl.jl#L78

Maybe this works without modification using the updated Graphs.jl package? Would be nice to move to this since Graphs.jl is the replacement for LightGraphs.jl.

zsunberg commented 1 year ago

Honestly, this is a leftover artifact from POMDPs.jl v0.8. We should just hardcode it. PR welcome.

zsunberg commented 1 year ago

Actually, it's not very trivial to do something simpler than a topological sort there. If someone makes a PR to switch to Graphs, I'm happy to accept it.

zsunberg commented 1 year ago

nvm, this was actually easy to switch

vancleve commented 1 year ago

cool!