search

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.
http://juliapomdp.github.io/POMDPs.jl/latest/
Other
657 stars 100 forks source link

`@POMDP_require` deprecation in POMDPTools #463

Closed WhiffleFish closed 1 year ago

WhiffleFish commented 1 year ago 
julia> using POMDPTools
[ Info: Precompiling POMDPTools [7588e00f-9cae-40de-98dc-e0c70c48cdd7]
┌ Warning: POMDPs.@POMDP_require is deprecated, use POMDPLinter.@POMDP_require instead.
└ @ POMDPs ~/code/random/POMDPs.jl/src/deprecated.jl:18
zsunberg commented 1 year ago

Yeah, this is super annoying. I do not know how to track it down though, ha. I guess we need to register POMDPs.jl 1.0 and remove POMDPs.@POMDP_require fully.

WhiffleFish commented 1 year ago

Is there anything stopping us from releasing a POMDPs.jl v0.10?

Anyways, it appears that changing @POMDP_require calls to explicit POMDPLinter.@POMDP_require calls fixes the issue.

If we're willing to admit this temporary workaround I can open a PR. If not, semver would suggest that moving from 0.9 to 0.10 would admit breaking changes. So technically it would be fine to remove POMDPs.@POMDP_require along with POMDPs.@req, POMDPs.@subreq, etc. in that version bump, no?

WhiffleFish commented 1 year ago

fixed by #466