search

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.
http://juliapomdp.github.io/POMDPs.jl/latest/
Other
657 stars 100 forks source link

CI badges look scary #478

Closed lassepe closed 1 year ago

lassepe commented 1 year ago

Entering the README with the CI badges below is pretty scary. Users may conclude that the package is broken/unmaintained. The breakage is not in the actual tests but in the documentation.

image

mykelk commented 1 year ago

So very true.

zsunberg commented 1 year ago

Agreed. Really, these things are misleading because they point to the master branch. Ideally they should point to something more reflective of the health of the package. I'll try to look into it.

@WhiffleFish do you remember why it is like this? Is there a quick fix? Maybe we can allow doc failures without calling it a CI failure?

WhiffleFish commented 1 year ago

I believe it's because the docs depend on master for POMDPs but the latest registered version for POMDPTools. The docs then fail to build because only the master version of POMDPTools is compatible with the master version of POMDPs.

This could possibly be fixed by also pushing POMDPTools src to the load path in docs/make.jl. However this would likely still break because other dependencies (POMDPModels and QuickPOMDPs) are not tested against master POMDPs.jl.

zsunberg commented 1 year ago

Hmmm... now the tests aren't even passing due to some things that look outdated. in POMDPTools test_belief.jl . @WhiffleFish can we talk about this tomorrow?

zsunberg commented 1 year ago

The broken tests are from a (correct) change I made to POMDPModels. A few tests in POMDPTools were incorrect, but also happened to work with the old version of POMDPModels

zsunberg commented 1 year ago

Ok, should be fixed now docs build with both POMDPs and POMDPTools masters

zsunberg commented 1 year ago

Fixed with #479