search

JuliaPOMDP / POMDPs.jl

MDPs and POMDPs in Julia - An interface for defining, solving, and simulating fully and partially observable Markov decision processes on discrete and continuous spaces.
http://juliapomdp.github.io/POMDPs.jl/latest/
Other
657 stars 100 forks source link

Not actually testing on MacOS/Windows #481

Closed WhiffleFish closed 1 year ago

WhiffleFish commented 1 year ago

All CI badges point to the same link.

We're only actually testing on ubuntu-latest as made evident in CI.yml.

zsunberg commented 1 year ago

My bad

image

zsunberg commented 1 year ago

We should definitely not lie on the README, but there are two solutions: 1) actually test on all OSs 2) just have one badge

I don't think there is any OS-specific code, so maybe we would be better citizens with solution (2) not taking up the resources. Also, at least in the olden days, testing on Windows and Mac was super annoying because it would take a long time for a machine to become available. On the other hand, people might be more confident in using it if they see that their OS has a green box next to it (though if they know what the green box means, they probably realize that it doesn't matter).

rejuvyesh commented 1 year ago

I think it's easy enough to test on multiple os with: runs-on: ${{ matrix.os }} and setting up the matrix.os appropriately. IMO we should test on the major 3 OS.

zsunberg commented 1 year ago

This was fixed with #486