search

JuliaPOMDP / RockSample.jl

Implement the rock sample problem using POMDPs.jl
Other
5 stars 5 forks source link

removed n_rocks; now inferred from position #1

Closed zsunberg closed 5 years ago

zsunberg commented 5 years ago

Hey @MaximeBouton

Nice package! I just noticed that you have to specify the number of rocks as a parameter to the constructor which is redundant with the rock positions. After some experimenting, I figured out how to get the constructor to handle it for you (seems like you had already tried to do this - it was very confusing to figure out how to do it without any warnings).

Anyways, merge if you think it looks good.

zsunberg commented 5 years ago

oh wait I accidentally added some wrong dependencies. Let me fix it.

codecov-io commented 5 years ago

Codecov Report

Merging #1 into master will increase coverage by 0.23%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #1      +/-   ##
==========================================
+ Coverage   85.03%   85.27%   +0.23%     
==========================================
  Files           7        7              
  Lines         127      129       +2     
==========================================
+ Hits          108      110       +2     
  Misses         19       19
Impacted Files Coverage Δ
src/states.jl 100% <100%> (ø) :arrow_up:
src/RockSample.jl 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b904ccf...50cf1ea. Read the comment docs.

MaximeBouton commented 5 years ago

Awesome thanks a lot!

MaximeBouton commented 5 years ago

I will let Travis finish and merge