search

JuliaPOMDP / RockSample.jl

Implement the rock sample problem using POMDPs.jl
Other
5 stars 5 forks source link

add compat helpers and more bounds #11

Closed MaximeBouton closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #11 (c1fbc2c) into master (23b739c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #11   +/-   ##
=======================================
  Coverage   85.86%   85.86%           
=======================================
  Files           8        8           
  Lines         184      184           
=======================================
  Hits          158      158           
  Misses         26       26

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 23b739c...c1fbc2c. Read the comment docs.

MaximeBouton commented 3 years ago

@Wu-Chenyang I set up the bounds to reasonable values without thinking much in order to register the package (now part of the general registry).

We can probably loosen the bound on StaticArrays. Although be aware that the other models from the ecosystem use another bound: https://github.com/JuliaPOMDP/POMDPModels.jl/blob/master/Project.toml#L27

Feel free to submit a PR with the new bounds though.