search

JuliaPOMDP / RockSample.jl

Implement the rock sample problem using POMDPs.jl
Other
5 stars 5 forks source link

Adding convert_s function #21

Closed yangyou95 closed 1 year ago

yangyou95 commented 1 year ago

Hi @zsunberg,

Thanks for your information yesterday. I add a convert_s function in RockSample.jl. I think it's working well. 👯

zsunberg commented 1 year ago

Thanks! This looks good to me! But wow, we should not have a test that solves a RockSample(15,15)! Once the tests pass I will merge it and then make a fix to make the tests run faster

zsunberg commented 1 year ago

Ok, I am just going to merge this and make some fixes in the master branch for simplicity's sake (this is bad practice, but :shrug: ). One small note: it is nice to put things in test sets for organization if the other sets are already in tests. Thanks for your contribution @yangyou95 !

zsunberg commented 1 year ago

@yangyou95 if you want to see the minor changes I made to make things nicer, they are here: https://github.com/JuliaPOMDP/RockSample.jl/commit/29fe16b6ea167bfcdc20575331747c4555c0b944