search

JuliaPOMDP / RockSample.jl

Implement the rock sample problem using POMDPs.jl
Other
5 stars 5 forks source link

fixed #25, replaced sample action index #26

Closed LorenzoBonanni closed 1 year ago

zsunberg commented 1 year ago

Hmm... it does seem like we need to fix #25, but currently the tests are failing for some reason.

LorenzoBonanni commented 1 year ago

I forgot to update the tests according to the new action indexes. I'll fix it in a couple of minutes.

LorenzoBonanni commented 1 year ago

@zsunberg now the tests pass

zsunberg commented 1 year ago

Great Thank you @LorenzoBonanni ! Do you think it is a good idea to tag a new version in the registry after this fix?

zsunberg commented 1 year ago

Since the actions could be considered part of the "public interface", and we changed that, I think we should tag version 0.2.0.

LorenzoBonanni commented 1 year ago

Yeah, that's fine the pull requests didn't add anything ground breaking adding 0.2.0 makes sense