search

JuliaPOMDP / SARSOP.jl

Julia package that wraps the SARSOP software for solving POMDPs/MDPs
Other
14 stars 7 forks source link

use SARSOP_jll! #38

Closed MaximeBouton closed 4 years ago

MaximeBouton commented 4 years ago

hopefully end of the build issues on windows.

MaximeBouton commented 4 years ago

Should fix #36 @zsunberg let me know if you want me to hold the merge. I bumped the version number to 0.5.0.

MaximeBouton commented 4 years ago

This version will NOT be compatible with julia 1.0 since it does not support artifacts.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-2.005%) to 90.678% when pulling 0014f2dc89cbd2138176693af504db3c7d366769 on sarsop_jll into 6c81922de7c64d913300d8c9a7dba445ad41119e on master.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-2.005%) to 90.678% when pulling 0014f2dc89cbd2138176693af504db3c7d366769 on sarsop_jll into 6c81922de7c64d913300d8c9a7dba445ad41119e on master.

zsunberg commented 4 years ago

I think we should merge this now!

zsunberg commented 4 years ago

oops, did not mean to close

rejuvyesh commented 4 years ago

We can support v1 via the old method if we want to. Would require a few version checks and some helper functions.

MaximeBouton commented 4 years ago

Right now if someone wants to use SARSOP in julia 1.0 it should install v0.4. If we make significant changes to the API at some point it might be worth having a build script with a version check.

zsunberg commented 4 years ago

I don't think it's necessary to support 1.0. There are much better things to use our time on!

Zachary Sunberg Assistant Professor Ann and H. J. Smead Aerospace Engineering Sciences University of Colorado Boulder https://zachary.sunberg.net/

On Fri, Mar 6, 2020 at 4:25 PM Maxime notifications@github.com wrote:

Right now if someone wants to use SARSOP in julia 1.0 it should install v0.4. If we make significant changes to the API at some point it might be worth having a build script with a version check.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/JuliaPOMDP/SARSOP.jl/pull/38?email_source=notifications&email_token=ABALI23VOLO4F2TBSS467CDRGGA67A5CNFSM4LCXMGLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODFOFY#issuecomment-596006679, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABALI2Y2Q2RXXGP3C2EE723RGGA67ANCNFSM4LCXMGLA .

mykelk commented 4 years ago

True!