search

JuliaPOMDP / TabularTDLearning.jl

Julia implementations of temporal difference Reinforcement Learning algorithms like Q-Learning and SARSA
Other
10 stars 6 forks source link

README.md example broken API #27

Closed filchristou closed 1 year ago

filchristou commented 1 year ago

Current README example doesn't work. Some simple modifications for it to play.

codecov[bot] commented 1 year ago

Codecov Report

Base: 97.12% // Head: 97.33% // Increases project coverage by +0.21% :tada:

Coverage data is based on head (e860605) compared to base (6935cb5). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #27 +/- ## ========================================== + Coverage 97.12% 97.33% +0.21% ========================================== Files 3 3 Lines 139 150 +11 ========================================== + Hits 135 146 +11 Misses 4 4 ``` | [Impacted Files](https://codecov.io/gh/JuliaPOMDP/TabularTDLearning.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPOMDP) | Coverage Δ | | |---|---|---| | [src/sarsa.jl](https://codecov.io/gh/JuliaPOMDP/TabularTDLearning.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPOMDP#diff-c3JjL3NhcnNhLmps) | `97.87% <0.00%> (+0.14%)` | :arrow_up: | | [src/q\_learn.jl](https://codecov.io/gh/JuliaPOMDP/TabularTDLearning.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPOMDP#diff-c3JjL3FfbGVhcm4uamw=) | `97.77% <0.00%> (+0.15%)` | :arrow_up: | | [src/sarsa\_lambda.jl](https://codecov.io/gh/JuliaPOMDP/TabularTDLearning.jl/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPOMDP#diff-c3JjL3NhcnNhX2xhbWJkYS5qbA==) | `96.55% <0.00%> (+0.32%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPOMDP). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaPOMDP)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

WhiffleFish commented 1 year ago

Great, thanks for the PR!